Let`s see #2183
Let`s see #2183
Conversation
There was a problem hiding this comment.
Great job on implementing the Machine class and ensuring the messages are informative! Just a few minor suggestions to enhance your code: consider using abstract references consistently and avoid redundant empty lines. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| public class Bulldozer extends Machine{ | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer is working"); |
There was a problem hiding this comment.
The message in the doWork method is informative and correctly indicates the type of Machine that is working.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer has stopped"); |
There was a problem hiding this comment.
The message in the stopWork method is informative and correctly indicates the type of Machine that has stopped.
| public class Excavator extends Machine{ | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator is working"); |
There was a problem hiding this comment.
The message in the doWork method should be more informative by indicating the type of Machine that is working, such as 'Excavator is starting to work'.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator has stopped"); |
There was a problem hiding this comment.
The message in the stopWork method should be more informative by indicating the type of Machine that has stopped, such as 'Excavator has stopped working'.
| public static void main(String[] args) { | ||
| Machine excavator = new Excavator(); | ||
| Machine truck = new Truck(); | ||
| Bulldozer bulldozer = new Bulldozer(); |
There was a problem hiding this comment.
You should use an abstract reference for the bulldozer variable as well. According to the checklist: 'Use abstract references instead of specific ones where possible.' Change Bulldozer bulldozer = new Bulldozer(); to Machine bulldozer = new Bulldozer();.
| m.stopWork(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There is a redundant empty line here. According to the checklist: 'Please don't add redundant empty lines to your code.'
| public class Truck extends Machine{ | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck is working"); |
There was a problem hiding this comment.
The message should indicate what type of Machine is working right now. Consider making the message more informative, such as 'Truck is starting to work'.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck has stopped"); |
There was a problem hiding this comment.
The message should indicate what type of Machine has stopped. Consider making the message more informative, such as 'Truck has stopped working'.
No description provided.